Cleanup: Better constify some strings in base.

base/debug/proc_maps_linux_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/proc_maps_linux.h"
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 221 matching lines @@
 }
 
 TEST(ProcMapsTest, ReadProcMapsNonEmptyString) {
   std::string old_string("I forgot to clear the string");
   std::string proc_maps(old_string);
   ASSERT_TRUE(ReadProcMaps(&proc_maps));
   EXPECT_EQ(std::string::npos, proc_maps.find(old_string));
 }
 
 TEST(ProcMapsTest, MissingFields) {
-  static const char* kTestCases[] = {
+  static const char* const kTestCases[] = {
     "00400000\n",                               // Missing end + beyond.
     "00400000-0040b000\n",                      // Missing perms + beyond.
     "00400000-0040b000 r-xp\n",                 // Missing offset + beyond.
     "00400000-0040b000 r-xp 00000000\n",        // Missing device + beyond.
     "00400000-0040b000 r-xp 00000000 fc:00\n",  // Missing inode + beyond.
     "00400000-0040b000 00000000 fc:00 794418 /bin/cat\n",  // Missing perms.
     "00400000-0040b000 r-xp fc:00 794418 /bin/cat\n",      // Missing offset.
     "00400000-0040b000 r-xp 00000000 fc:00 /bin/cat\n",    // Missing inode.
     "00400000 r-xp 00000000 fc:00 794418 /bin/cat\n",      // Missing end.
     "-0040b000 r-xp 00000000 fc:00 794418 /bin/cat\n",     // Missing start.
     "00400000-0040b000 r-xp 00000000 794418 /bin/cat\n",   // Missing device.
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     SCOPED_TRACE(base::StringPrintf("kTestCases[%zu] = %s", i, kTestCases[i]));
     std::vector<MappedMemoryRegion> regions;
     EXPECT_FALSE(ParseProcMaps(kTestCases[i], &regions));
   }
 }
 
 TEST(ProcMapsTest, InvalidInput) {
-  static const char* kTestCases[] = {
+  static const char* const kTestCases[] = {
     "thisisal-0040b000 rwxp 00000000 fc:00 794418 /bin/cat\n",
     "0040000d-linvalid rwxp 00000000 fc:00 794418 /bin/cat\n",
     "00400000-0040b000 inpu 00000000 fc:00 794418 /bin/cat\n",
     "00400000-0040b000 rwxp tforproc fc:00 794418 /bin/cat\n",
     "00400000-0040b000 rwxp 00000000 ma:ps 794418 /bin/cat\n",
     "00400000-0040b000 rwxp 00000000 fc:00 parse! /bin/cat\n",
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
     SCOPED_TRACE(base::StringPrintf("kTestCases[%zu] = %s", i, kTestCases[i]));
@@ skipping 29 matching lines @@
   EXPECT_EQ(5ULL, regions.size());
   EXPECT_EQ("/bin/cat", regions[0].path);
   EXPECT_EQ("/lib/x86_64-linux-gnu/libc-2.15.so", regions[1].path);
   EXPECT_EQ("/lib/x86_64-linux-gnu/ld-2.15.so", regions[2].path);
   EXPECT_EQ("\"vd so\"", regions[3].path);
   EXPECT_EQ("[vsys call]", regions[4].path);
 }
 
 }  // namespace debug
 }  // namespace base