base/metrics/field_trial_unittest.cc - Issue 632103004: Cleanup: Better constify some strings in base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/field_trial_unittest.cc

Issue 632103004: Cleanup: Better constify some strings in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lint Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/field_trial_unittest.cc

diff --git a/base/metrics/field_trial_unittest.cc b/base/metrics/field_trial_unittest.cc

index 52ce8554db06e98ff1ba88b98d8994072e491c80..e9b059a28340d1e7c74e64bbe8c633603bb0aa99 100644

--- a/base/metrics/field_trial_unittest.cc

+++ b/base/metrics/field_trial_unittest.cc

@@ -78,8 +78,8 @@ class FieldTrialTest : public testing::Test {

// Test registration, and also check that destructors are called for trials

// (and that Valgrind doesn't catch us leaking).

TEST_F(FieldTrialTest, Registration) {

- const char* name1 = "name 1 test";

- const char* name2 = "name 2 test";

+ const char name1[] = "name 1 test";

+ const char name2[] = "name 2 test";

EXPECT_FALSE(FieldTrialList::Find(name1));

EXPECT_FALSE(FieldTrialList::Find(name2));