Cleanup: Better constify some strings in base.

base/prefs/overlay_user_pref_store_unittest.cc

Index: base/prefs/overlay_user_pref_store_unittest.cc
diff --git a/base/prefs/overlay_user_pref_store_unittest.cc b/base/prefs/overlay_user_pref_store_unittest.cc
index 18e9a5c99106c95e8c1347622cd52fffbcc95aa6..66a7b3bd1a80685aecaf0fb0d6ae313fe4317193 100644
--- a/base/prefs/overlay_user_pref_store_unittest.cc
+++ b/base/prefs/overlay_user_pref_store_unittest.cc
@@ -19,12 +19,12 @@ namespace {
 const char kBrowserWindowPlacement[] = "browser.window_placement";
 const char kShowBookmarkBar[] = "bookmark_bar.show_on_all_tabs";
 
-const char* overlay_key = kBrowserWindowPlacement;
-const char* regular_key = kShowBookmarkBar;
+const char* const overlay_key = kBrowserWindowPlacement;
+const char* const regular_key = kShowBookmarkBar;
 // With the removal of the kWebKitGlobalXXX prefs, we'll no longer have real
 // prefs using the overlay pref store, so make up keys here.
-const char* mapped_overlay_key = "test.per_tab.javascript_enabled";
-const char* mapped_underlay_key = "test.per_profile.javascript_enabled";
+const char mapped_overlay_key[] = "test.per_tab.javascript_enabled";

[danakj, 2014/10/07 17:13:54]

why not const char* const also?

[Lei Zhang, 2014/10/17 21:19:38]

const char foo[] is preferred over const char* const foo, but in some cases, it
needs to be a pointer. These don't need to be pointers.

+const char mapped_underlay_key[] = "test.per_profile.javascript_enabled";
 
 }  // namespace