Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: Source/web/ColorChooserPopupUIController.h

Issue 631833002: Move color chooser objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Keep ~ColorInputType empty Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/ColorChooserPopupUIController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ColorChooserPopupUIController.h
diff --git a/Source/web/ColorChooserPopupUIController.h b/Source/web/ColorChooserPopupUIController.h
index 389eaf99a0e6a9276696c8cdbcf33e98f43007f4..b0694b3178782a2b200c672d6dc2eb1dfc26fdc5 100644
--- a/Source/web/ColorChooserPopupUIController.h
+++ b/Source/web/ColorChooserPopupUIController.h
@@ -39,7 +39,11 @@ class PagePopup;
class ColorChooserPopupUIController final : public ColorChooserUIController, public PagePopupClient {
public:
- ColorChooserPopupUIController(LocalFrame*, ChromeClientImpl*, ColorChooserClient*);
+ static PassOwnPtrWillBeRawPtr<ColorChooserPopupUIController> create(LocalFrame* frame, ChromeClientImpl* chromeClient, ColorChooserClient* client)
+ {
+ return adoptPtrWillBeNoop(new ColorChooserPopupUIController(frame, chromeClient, client));
+ }
+
virtual ~ColorChooserPopupUIController();
// ColorChooserUIController functions:
@@ -60,14 +64,15 @@ public:
virtual void didClosePopup() override;
private:
+ ColorChooserPopupUIController(LocalFrame*, ChromeClientImpl*, ColorChooserClient*);
+
void openPopup();
ChromeClientImpl* m_chromeClient;
- ColorChooserClient* m_client;
PagePopup* m_popup;
Locale& m_locale;
};
-}
+} // namespace blink
#endif // ColorChooserPopupUIController_h
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/ColorChooserPopupUIController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698