Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: Source/web/ColorChooserPopupUIController.h

Issue 631833002: Move color chooser objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Keep ~ColorInputType empty Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/ColorChooserPopupUIController.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 21 matching lines...) Expand all
32 32
33 namespace blink { 33 namespace blink {
34 34
35 class ChromeClientImpl; 35 class ChromeClientImpl;
36 class ColorChooserClient; 36 class ColorChooserClient;
37 class PagePopup; 37 class PagePopup;
38 38
39 class ColorChooserPopupUIController final : public ColorChooserUIController, pub lic PagePopupClient { 39 class ColorChooserPopupUIController final : public ColorChooserUIController, pub lic PagePopupClient {
40 40
41 public: 41 public:
42 ColorChooserPopupUIController(LocalFrame*, ChromeClientImpl*, ColorChooserCl ient*); 42 static PassOwnPtrWillBeRawPtr<ColorChooserPopupUIController> create(LocalFra me* frame, ChromeClientImpl* chromeClient, ColorChooserClient* client)
43 {
44 return adoptPtrWillBeNoop(new ColorChooserPopupUIController(frame, chrom eClient, client));
45 }
46
43 virtual ~ColorChooserPopupUIController(); 47 virtual ~ColorChooserPopupUIController();
44 48
45 // ColorChooserUIController functions: 49 // ColorChooserUIController functions:
46 virtual void openUI() override; 50 virtual void openUI() override;
47 51
48 // ColorChooser functions 52 // ColorChooser functions
49 virtual void endChooser() override; 53 virtual void endChooser() override;
50 virtual AXObject* rootAXObject() override; 54 virtual AXObject* rootAXObject() override;
51 55
52 // PagePopupClient functions: 56 // PagePopupClient functions:
53 virtual IntSize contentSize() override; 57 virtual IntSize contentSize() override;
54 virtual void writeDocument(SharedBuffer*) override; 58 virtual void writeDocument(SharedBuffer*) override;
55 virtual Locale& locale() override; 59 virtual Locale& locale() override;
56 virtual void setValueAndClosePopup(int, const String&) override; 60 virtual void setValueAndClosePopup(int, const String&) override;
57 virtual void setValue(const String&) override; 61 virtual void setValue(const String&) override;
58 virtual void closePopup() override; 62 virtual void closePopup() override;
59 virtual Element& ownerElement() override; 63 virtual Element& ownerElement() override;
60 virtual void didClosePopup() override; 64 virtual void didClosePopup() override;
61 65
62 private: 66 private:
67 ColorChooserPopupUIController(LocalFrame*, ChromeClientImpl*, ColorChooserCl ient*);
68
63 void openPopup(); 69 void openPopup();
64 70
65 ChromeClientImpl* m_chromeClient; 71 ChromeClientImpl* m_chromeClient;
66 ColorChooserClient* m_client;
67 PagePopup* m_popup; 72 PagePopup* m_popup;
68 Locale& m_locale; 73 Locale& m_locale;
69 }; 74 };
70 75
71 } 76 } // namespace blink
72 77
73 #endif // ColorChooserPopupUIController_h 78 #endif // ColorChooserPopupUIController_h
OLDNEW
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/ColorChooserPopupUIController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698