Move color chooser objects to the Oilpan heap.

Source/web/ColorChooserPopupUIController.cpp

Index: Source/web/ColorChooserPopupUIController.cpp
diff --git a/Source/web/ColorChooserPopupUIController.cpp b/Source/web/ColorChooserPopupUIController.cpp
index c2bb507f2ccfc29d360dee903b3e70947683dde3..163d4164e623d267c31ed239d2f663e7b8383c4a 100644
--- a/Source/web/ColorChooserPopupUIController.cpp
+++ b/Source/web/ColorChooserPopupUIController.cpp
@@ -55,6 +55,14 @@ ColorChooserPopupUIController::ColorChooserPopupUIController(LocalFrame* frame,
 
 ColorChooserPopupUIController::~ColorChooserPopupUIController()

[haraken, 2014/10/07 03:31:29]

Can we add ASSERT(!m_popup) ?

[sof, 2014/10/07 06:35:19]

I'm quite likely missing some invariant, but why can we assume so?

[haraken, 2014/10/07 06:43:59]

Sorry, I was misreading the code. We cannot assume that.

 {
+    endChooser();

[tkent, 2014/10/07 02:25:00]

endChooser() touches m_chooser and m_popup, and both of them are off-heap.  This
is safe.

[haraken, 2014/10/07 03:31:29]

Both ~ColorChooserPopupUIController and ~ColorChooserUIController call
endChooser(), which is not that nice.

Can we rewrite the code like this?

virtual ~ColorChooserUIController() {
  endChooser();
}

virtual ~ColorChooserPopupUIController {
  if (m_popup)
    closePopup();
}

[sof, 2014/10/07 06:35:19]

That changes the order for the popup controller, closing the popup page
earlier/first.

endChooser() isn't invoked twice, somewhat stodgily achieved perhaps, but I
prefer to keep it the way it is now/here.

[haraken, 2014/10/07 06:43:59]

Does the order matter?

Not related to this CL, it looks not nice to call endChooser() in both 
~ColorChooserPopupUIController and ~ColorChooserUIController. If the order
doesn't matter, it looks better to remove endChooser() in
~ColorChooserPopupUIController.

+    m_chooser = nullptr;
+}
+
+void ColorChooserPopupUIController::trace(Visitor* visitor)
+{
+    visitor->trace(m_client);
+    ColorChooserUIController::trace(visitor);
 }
 
 void ColorChooserPopupUIController::openUI()