Move color chooser objects to the Oilpan heap.

Source/web/ColorChooserPopupUIController.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 35 matching lines @@
 
 ColorChooserPopupUIController::ColorChooserPopupUIController(LocalFrame* frame, ChromeClientImpl* chromeClient, ColorChooserClient* client)
     : ColorChooserUIController(frame, client)
     , m_chromeClient(chromeClient)
     , m_client(client)
     , m_popup(0)
     , m_locale(Locale::defaultLocale())
 {
 }
 
 ColorChooserPopupUIController::~ColorChooserPopupUIController()

[haraken, 2014/10/07 03:31:29]

Can we add ASSERT(!m_popup) ?

[sof, 2014/10/07 06:35:19]

I'm quite likely missing some invariant, but why can we assume so?

[haraken, 2014/10/07 06:43:59]

Sorry, I was misreading the code. We cannot assume that.

 {
+    endChooser();

[tkent, 2014/10/07 02:25:00]

endChooser() touches m_chooser and m_popup, and both of them are off-heap.  This
is safe.

[haraken, 2014/10/07 03:31:29]

Both ~ColorChooserPopupUIController and ~ColorChooserUIController call
endChooser(), which is not that nice.

Can we rewrite the code like this?

virtual ~ColorChooserUIController() {
  endChooser();
}

virtual ~ColorChooserPopupUIController {
  if (m_popup)
    closePopup();
}

[sof, 2014/10/07 06:35:19]

That changes the order for the popup controller, closing the popup page
earlier/first.

endChooser() isn't invoked twice, somewhat stodgily achieved perhaps, but I
prefer to keep it the way it is now/here.

[haraken, 2014/10/07 06:43:59]

Does the order matter?

Not related to this CL, it looks not nice to call endChooser() in both 
~ColorChooserPopupUIController and ~ColorChooserUIController. If the order
doesn't matter, it looks better to remove endChooser() in
~ColorChooserPopupUIController.

+    m_chooser = nullptr;
+}
+
+void ColorChooserPopupUIController::trace(Visitor* visitor)
+{
+    visitor->trace(m_client);
+    ColorChooserUIController::trace(visitor);
 }
 
 void ColorChooserPopupUIController::openUI()
 {
     if (m_client->shouldShowSuggestions())
         openPopup();
     else
         openColorChooser();
 }
 
@@ skipping 82 matching lines @@
 }
 
 void ColorChooserPopupUIController::closePopup()
 {
     if (!m_popup)
         return;
     m_chromeClient->closePagePopup(m_popup);
 }
 
 } // namespace blink