Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8151)

Unified Diff: chrome/browser/ui/cocoa/dev_tools_controller.h

Issue 63173016: DevTools: place DevTools WebContents underneath inspected WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/dev_tools_controller.h
diff --git a/chrome/browser/ui/cocoa/dev_tools_controller.h b/chrome/browser/ui/cocoa/dev_tools_controller.h
index 8684e9c25857b22ddd40b391133369efbf642f31..a97b19a7f00ca170781f9b312fd906f47eadbe14 100644
--- a/chrome/browser/ui/cocoa/dev_tools_controller.h
+++ b/chrome/browser/ui/cocoa/dev_tools_controller.h
@@ -11,7 +11,7 @@
#include "chrome/browser/devtools/devtools_window.h"
@class FocusTracker;
-@class GraySplitView;
+@class DevToolsContainerView;
class Profile;
namespace content {
@@ -21,12 +21,10 @@ class WebContents;
// A class that handles updates of the devTools view within a browser window.
// It swaps in the relevant devTools contents for a given WebContents or removes
// the view, if there's no devTools contents to show.
-@interface DevToolsController : NSObject<NSSplitViewDelegate> {
+@interface DevToolsController : NSObject {
@private
// A view hosting docked devTools contents.
- base::scoped_nsobject<GraySplitView> splitView_;
-
- DevToolsDockSide dockSide_;
+ base::scoped_nsobject<DevToolsContainerView> devToolsContainerView_;
// Docked devtools window instance. NULL when current tab is not inspected
// or is inspected with undocked version of DevToolsWindow.
@@ -40,13 +38,8 @@ class WebContents;
// This controller's view.
- (NSView*)view;
-// The compiler seems to have trouble handling a function named "view" that
-// returns an NSSplitView, so provide a differently-named method.
-- (NSSplitView*)splitView;
-
// Depending on |contents|'s state, decides whether the docked web inspector
-// should be shown or hidden and adjusts its height (|delegate_| handles
-// the actual resize).
+// should be shown or hidden and adjusts inspected page position.
- (void)updateDevToolsForWebContents:(content::WebContents*)contents
withProfile:(Profile*)profile;
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/dev_tools_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698