Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6143)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 63173016: DevTools: place DevTools WebContents underneath inspected WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
index 22576b484d7e4451d9abf06e53550ce901ed74f9..7a8615cfe8dc299cfc18fd61f2f509c38f0865fe 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
@@ -70,10 +70,6 @@ using ::testing::Return;
return [findBarCocoaController_ view];
}
-- (NSSplitView*)devToolsView {
- return static_cast<NSSplitView*>([devToolsController_ view]);
-}
-
- (BOOL)bookmarkBarVisible {
return [bookmarkBarController_ isVisible];
}
@@ -633,24 +629,6 @@ TEST_F(BrowserWindowControllerTest, TestFindBarOnTop) {
EXPECT_GT(findBar_index, bookmark_index);
}
-// Tests that status bubble's base frame does move when devTools are docked.
-TEST_F(BrowserWindowControllerTest, TestStatusBubblePositioning) {
- ASSERT_EQ(1U, [[[controller_ devToolsView] subviews] count]);
-
- NSPoint bubbleOrigin = [controller_ statusBubbleBaseFrame].origin;
-
- // Add a fake subview to devToolsView to emulate docked devTools.
- base::scoped_nsobject<NSView> view(
- [[NSView alloc] initWithFrame:NSMakeRect(0, 0, 10, 10)]);
- [[controller_ devToolsView] addSubview:view];
- [[controller_ devToolsView] adjustSubviews];
-
- NSPoint bubbleOriginWithDevTools = [controller_ statusBubbleBaseFrame].origin;
-
- // Make sure that status bubble frame is moved.
- EXPECT_FALSE(NSEqualPoints(bubbleOrigin, bubbleOriginWithDevTools));
-}
-
TEST_F(BrowserWindowControllerTest, TestSigninMenuItemNoErrors) {
base::scoped_nsobject<NSMenuItem> syncMenuItem(
[[NSMenuItem alloc] initWithTitle:@""
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm ('k') | chrome/browser/ui/cocoa/dev_tools_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698