Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5970)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 63173016: DevTools: place DevTools WebContents underneath inspected WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
index e1af59d1be9d54223fe5602d5ed7f174ac44d01b..6e74ae1db38dae86c8c5c4a1ee44c62132039f5a 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
@@ -8,6 +8,7 @@
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/infobars/simple_alert_infobar_delegate.h"
#include "chrome/browser/profiles/profile.h"
@@ -141,6 +142,11 @@ class BrowserWindowControllerTest : public InProcessBrowserTest {
return height;
}
+ void SetDevToolsWindowContentsInsets(
+ DevToolsWindow* window, int left, int top, int right, int bottom) {
+ window->SetContentsInsets(left, top, right, bottom);
+ }
+
private:
DISALLOW_COPY_AND_ASSIGN(BrowserWindowControllerTest);
};
@@ -366,3 +372,16 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
overlay.reset();
EXPECT_TRUE(web_contents_view->GetAllowOverlappingViews());
}
+
+// Tests that status bubble's base frame does move when devTools are docked.
+IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
+ StatusBubblePositioning) {
+ NSPoint origin = [controller() statusBubbleBaseFrame].origin;
+
+ DevToolsWindow* devtools_window = DevToolsWindow::ToggleDevToolsWindow(
+ browser(), DevToolsToggleAction::Show());
+ SetDevToolsWindowContentsInsets(devtools_window, 10, 10, 10, 10);
+
+ NSPoint originWithDevTools = [controller() statusBubbleBaseFrame].origin;
+ EXPECT_FALSE(NSEqualPoints(origin, originWithDevTools));
+}
« no previous file with comments | « chrome/browser/ui/browser_ui_prefs.cc ('k') | chrome/browser/ui/cocoa/browser_window_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698