DevTools: place DevTools WebContents underneath inspected WebContents.

chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
index 22576b484d7e4451d9abf06e53550ce901ed74f9..7a8615cfe8dc299cfc18fd61f2f509c38f0865fe 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
@@ -70,10 +70,6 @@ using ::testing::Return;
   return [findBarCocoaController_ view];
 }
 
-- (NSSplitView*)devToolsView {
-  return static_cast<NSSplitView*>([devToolsController_ view]);
-}
-
 - (BOOL)bookmarkBarVisible {
   return [bookmarkBarController_ isVisible];
 }
@@ -633,24 +629,6 @@ TEST_F(BrowserWindowControllerTest, TestFindBarOnTop) {
   EXPECT_GT(findBar_index, bookmark_index);
 }
 
-// Tests that status bubble's base frame does move when devTools are docked.

[Avi (use Gerrit), 2013/12/09 16:13:36]

Is there an equivalent test you can add, to test that the status bubble moves
when the devtools encloses the web page? Losing a test makes me sad,
particularly because it's a regression test for http://crbug.com/54882 .

[dgozman, 2013/12/09 21:09:11]

What do you think, if we use performSelector: here to call methods from
implementation?
Otherwise, It looks undoable here in unit tests.
Or maybe, there is a browser test which does something similar, so I can mimic
it? I'm not familiar with Mac-specific tests at all :(

[dgozman, 2013/12/10 14:51:47]

I've added BrowserWindowControllerTest.StatusBubblePositioning instead of this.

[Avi (use Gerrit), 2013/12/10 16:32:40]

Sweet, thanks.

-TEST_F(BrowserWindowControllerTest, TestStatusBubblePositioning) {
-  ASSERT_EQ(1U, [[[controller_ devToolsView] subviews] count]);
-
-  NSPoint bubbleOrigin = [controller_ statusBubbleBaseFrame].origin;
-
-  // Add a fake subview to devToolsView to emulate docked devTools.
-  base::scoped_nsobject<NSView> view(
-      [[NSView alloc] initWithFrame:NSMakeRect(0, 0, 10, 10)]);
-  [[controller_ devToolsView] addSubview:view];
-  [[controller_ devToolsView] adjustSubviews];
-
-  NSPoint bubbleOriginWithDevTools = [controller_ statusBubbleBaseFrame].origin;
-
-  // Make sure that status bubble frame is moved.
-  EXPECT_FALSE(NSEqualPoints(bubbleOrigin, bubbleOriginWithDevTools));
-}
-
 TEST_F(BrowserWindowControllerTest, TestSigninMenuItemNoErrors) {
   base::scoped_nsobject<NSMenuItem> syncMenuItem(
       [[NSMenuItem alloc] initWithTitle:@""