DevTools: place DevTools WebContents underneath inspected WebContents.

chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
@@ skipping 52 matching lines @@
 }
 
 - (NSView*)bookmarkView {
   return [bookmarkBarController_ view];
 }
 
 - (NSView*)findBarView {
   return [findBarCocoaController_ view];
 }
 
-- (NSSplitView*)devToolsView {
-  return static_cast<NSSplitView*>([devToolsController_ view]);
-}
-
 - (BOOL)bookmarkBarVisible {
   return [bookmarkBarController_ isVisible];
 }
 @end
 
 class BrowserWindowControllerTest : public CocoaProfileTest {
  public:
   virtual void SetUp() {
     CocoaProfileTest::SetUp();
     ASSERT_TRUE(browser());
@@ skipping 539 matching lines @@
       [subviews indexOfObject:[controller_ toolbarView]];
   EXPECT_NE(NSNotFound, toolbar_index);
   NSUInteger bookmark_index =
       [subviews indexOfObject:[controller_ bookmarkView]];
   EXPECT_NE(NSNotFound, bookmark_index);
 
   EXPECT_GT(findBar_index, toolbar_index);
   EXPECT_GT(findBar_index, bookmark_index);
 }
 
-// Tests that status bubble's base frame does move when devTools are docked.

[Avi (use Gerrit), 2013/12/09 16:13:36]

Is there an equivalent test you can add, to test that the status bubble moves
when the devtools encloses the web page? Losing a test makes me sad,
particularly because it's a regression test for http://crbug.com/54882 .

[dgozman, 2013/12/09 21:09:11]

What do you think, if we use performSelector: here to call methods from
implementation?
Otherwise, It looks undoable here in unit tests.
Or maybe, there is a browser test which does something similar, so I can mimic
it? I'm not familiar with Mac-specific tests at all :(

[dgozman, 2013/12/10 14:51:47]

I've added BrowserWindowControllerTest.StatusBubblePositioning instead of this.

[Avi (use Gerrit), 2013/12/10 16:32:40]

Sweet, thanks.

-TEST_F(BrowserWindowControllerTest, TestStatusBubblePositioning) {
-  ASSERT_EQ(1U, [[[controller_ devToolsView] subviews] count]);
-
-  NSPoint bubbleOrigin = [controller_ statusBubbleBaseFrame].origin;
-
-  // Add a fake subview to devToolsView to emulate docked devTools.
-  base::scoped_nsobject<NSView> view(
-      [[NSView alloc] initWithFrame:NSMakeRect(0, 0, 10, 10)]);
-  [[controller_ devToolsView] addSubview:view];
-  [[controller_ devToolsView] adjustSubviews];
-
-  NSPoint bubbleOriginWithDevTools = [controller_ statusBubbleBaseFrame].origin;
-
-  // Make sure that status bubble frame is moved.
-  EXPECT_FALSE(NSEqualPoints(bubbleOrigin, bubbleOriginWithDevTools));
-}
-
 TEST_F(BrowserWindowControllerTest, TestSigninMenuItemNoErrors) {
   base::scoped_nsobject<NSMenuItem> syncMenuItem(
       [[NSMenuItem alloc] initWithTitle:@""
                                  action:@selector(commandDispatch)
                           keyEquivalent:@""]);
   [syncMenuItem setTag:IDC_SHOW_SYNC_SETUP];
 
   NSString* startSignin =
     l10n_util::GetNSStringFWithFixup(
         IDS_SYNC_MENU_PRE_SYNCED_LABEL,
@@ skipping 234 matching lines @@
   testFullscreenWindow_.reset(
       [[NSWindow alloc] initWithContentRect:NSMakeRect(0,0,400,400)
                                   styleMask:NSBorderlessWindowMask
                                     backing:NSBackingStoreBuffered
                                       defer:NO]);
   return testFullscreenWindow_.get();
 }
 @end
 
 /* TODO(???): test other methods of BrowserWindowController */