Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 631653002: Replacing the OVERRIDE with override in tools folder (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override in tools folder This step is a giant search and replace for OVERRIDE to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/6bf6f20cdedc5e85c87c5b6f6686706a72a63f0c Cr-Commit-Position: refs/heads/master@{#300594}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Corrected patch-set-1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -137 lines) Patch
M tools/android/forwarder2/device_forwarder_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/android/heap_profiler/heap_profiler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/action_target_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/binary_target_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/builder_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/gn/config.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/copy_target_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/group_target_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/loader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/gn/ninja_action_target_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_binary_target_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_copy_target_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_group_target_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_target_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/parse_tree.h View 11 chunks +55 lines, -55 lines 0 comments Download
M tools/gn/scope_per_file_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/setup.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/target.h View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gn/toolchain.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/ipc_fuzzer/mutate/generate.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M tools/ipc_fuzzer/mutate/mutate.cc View 3 chunks +30 lines, -30 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay_process.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 06:20:40 UTC) #2
Ben Goodger (Google)
https://codereview.chromium.org/631653002/diff/1/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h File tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h (right): https://codereview.chromium.org/631653002/diff/1/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h#newcode5 tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h:5: #ifndef CLASS_REQUIRES_finalIZATION_BASE_H_ oops https://codereview.chromium.org/631653002/diff/1/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h File tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h (right): https://codereview.chromium.org/631653002/diff/1/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h#newcode5 tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h:5: ...
6 years, 2 months ago (2014-10-07 19:47:03 UTC) #3
MRV
Dear Mr. Thanks for feedback. Changes were incorporated in patch-set-2. PTAL https://codereview.chromium.org/631653002/diff/1/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h File tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h (right): ...
6 years, 2 months ago (2014-10-08 03:12:08 UTC) #4
MRV
On 2014/10/07 19:47:03, Ben Goodger (Google) wrote: > https://codereview.chromium.org/631653002/diff/1/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h > File tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h > (right): > ...
6 years, 2 months ago (2014-10-08 03:12:56 UTC) #5
MRV
On 2014/10/08 03:12:56, MRV wrote: > On 2014/10/07 19:47:03, Ben Goodger (Google) wrote: > > ...
6 years, 2 months ago (2014-10-09 13:57:20 UTC) #6
MRV
On 2014/10/09 13:57:20, MRV wrote: > On 2014/10/08 03:12:56, MRV wrote: > > On 2014/10/07 ...
6 years, 2 months ago (2014-10-10 00:47:22 UTC) #7
Mostyn Bramley-Moore
@Ben: *ping* this is the one of the few CLs remaining that we need to ...
6 years, 2 months ago (2014-10-16 18:59:26 UTC) #8
Peter Kasting
Note that https://codereview.chromium.org/643063004/ probably does everything this CL is doing for tools/gn/ .
6 years, 2 months ago (2014-10-21 22:48:55 UTC) #9
Peter Kasting
On 2014/10/21 22:48:55, Peter Kasting wrote: > Note that https://codereview.chromium.org/643063004/ probably does everything > this ...
6 years, 2 months ago (2014-10-21 22:52:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631653002/20001
6 years, 2 months ago (2014-10-21 22:55:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 01:10:17 UTC) #13
MRV
On 2014/10/21 22:52:22, Peter Kasting wrote: > On 2014/10/21 22:48:55, Peter Kasting wrote: > > ...
6 years, 2 months ago (2014-10-22 04:00:10 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:04:34 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6bf6f20cdedc5e85c87c5b6f6686706a72a63f0c
Cr-Commit-Position: refs/heads/master@{#300594}

Powered by Google App Engine
This is Rietveld 408576698