Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: rlz/lib/rlz_lib.h

Issue 63153009: Use RegistryOverrideManager properly in RLZ tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added doc comment for InitializeRegistryOverridesForTesting Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: rlz/lib/rlz_lib.h
diff --git a/rlz/lib/rlz_lib.h b/rlz/lib/rlz_lib.h
index 1f8be5ca2d54966ea258d4742abfdc1a05a2464d..6e3f451fc1589d358d6276d7df72ddae1d601d5a 100644
--- a/rlz/lib/rlz_lib.h
+++ b/rlz/lib/rlz_lib.h
@@ -52,6 +52,22 @@ class URLRequestContextGetter;
namespace rlz_lib {
+// All functions return true on success and false on error.
grt (UTC plus 2) 2013/11/13 04:23:47 rogerta: i extracted this comment from win/lib/rlz
Roger Tawa OOO till Jul 10th 2013/11/13 18:39:31 Looks fine. This file still contains a lot of win
+// This implemenation is thread safe.
+//
+// Each prototype mentions the registry access requirements:
+//
+// HKLM read: Will work from any process and at any privilege level on Vista.
+// HKCU read: Calls made from the SYSTEM account must pass the current user's
+// SID as the optional 'sid' param. Can be called from low integrity
+// process on Vista.
+// HKCU write: Calls made from the SYSTEM account must pass the current user's
+// SID as the optional 'sid' param. Calls require at least medium
+// integrity on Vista (e.g. Toolbar will need to use their broker)
+// HKLM write: Calls must be made from an account with admin rights. No SID
+// need be passed when running as SYSTEM.
+// Functions which do not access registry will be marked with "no restrictions".
+
class ScopedRlzValueStoreLock;
// The maximum length of an access points RLZ in bytes.
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | rlz/rlz.gyp » ('j') | rlz/test/rlz_test_helpers.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698