Use RegistryOverrideManager properly in RLZ tests.

rlz/lib/rlz_lib.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A library to manage RLZ information for access-points shared
 // across different client applications.
 //
 // All functions return true on success and false on error.
 // This implemenation is thread safe.
 
@@ skipping 34 matching lines @@
 #endif
 
 #if defined(RLZ_NETWORK_IMPLEMENTATION_CHROME_NET)
 namespace net {
 class URLRequestContextGetter;
 }  // namespace net
 #endif
 
 namespace rlz_lib {
 
+// All functions return true on success and false on error.

[grt (UTC plus 2), 2013/11/13 04:23:47]

rogerta: i extracted this comment from win/lib/rlz_lib.h (which i've deleted).
it seemed to fit here.

[Roger Tawa OOO till Jul 10th, 2013/11/13 18:39:31]

Looks fine.  This file still contains a lot of windows specific comments even
though its used on all platforms.

+// This implemenation is thread safe.
+//
+// Each prototype mentions the registry access requirements:
+//
+// HKLM read:  Will work from any process and at any privilege level on Vista.
+// HKCU read:  Calls made from the SYSTEM account must pass the current user's
+//             SID as the optional 'sid' param. Can be called from low integrity
+//             process on Vista.
+// HKCU write: Calls made from the SYSTEM account must pass the current user's
+//             SID as the optional 'sid' param. Calls require at least medium
+//             integrity on Vista (e.g. Toolbar will need to use their broker)
+// HKLM write: Calls must be made from an account with admin rights. No SID
+//             need be passed when running as SYSTEM.
+// Functions which do not access registry will be marked with "no restrictions".
+
 class ScopedRlzValueStoreLock;
 
 // The maximum length of an access points RLZ in bytes.
 const size_t kMaxRlzLength = 64;
 // The maximum length of an access points RLZ in bytes.
 const size_t kMaxDccLength = 128;
 // The maximum length of a CGI string in bytes.
 const size_t kMaxCgiLength = 2048;
 // The maximum length of a ping response we will parse in bytes. If the response
 // is bigger, please break it up into separate calls.
@@ skipping 261 matching lines @@
 
   static const std::string& GetBrand();
 
  private:
   ScopedRlzValueStoreLock* lock_;
 };
 
 }  // namespace rlz_lib
 
 #endif  // RLZ_LIB_RLZ_LIB_H_