src/globals.h - Issue 631433002: Classes runtime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/globals.h

Issue 631433002: Classes runtime (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Create prototype object with initial prototype parent Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/globals.h

diff --git a/src/globals.h b/src/globals.h

index 3d8f57aadde42aa8a4eb06429b0b3911af3707f8..775290155ac83de6e9e6bb266e2a79f510e3737b 100644

--- a/src/globals.h

+++ b/src/globals.h

@@ -765,7 +765,8 @@ enum FunctionKind {

kArrowFunction = 1,

kGeneratorFunction = 2,

kConciseMethod = 4,

- kConciseGeneratorMethod = kGeneratorFunction | kConciseMethod

+ kConciseGeneratorMethod = kGeneratorFunction | kConciseMethod,

+ kConstructorMethod = kNormalFunction

Dmitry Lomov (no reviews) 2014/10/07 15:09:37 Set but unused? Let's remove it.

arv (Not doing code reviews) 2014/10/07 15:16:52 It is used in preparser.h. I can change that to us

Dmitry Lomov (no reviews) 2014/10/07 15:21:05 Right, I've seen that. Let's not add constants tha

arv (Not doing code reviews) 2014/10/07 16:13:18 Done.

};