Classes runtime

src/globals.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_GLOBALS_H_
 #define V8_GLOBALS_H_
 
 #include "include/v8stdint.h"
 
 #include "src/base/build_config.h"
@@ skipping 747 matching lines @@
 
 
 enum Signedness { kSigned, kUnsigned };
 
 
 enum FunctionKind {
   kNormalFunction = 0,
   kArrowFunction = 1,
   kGeneratorFunction = 2,
   kConciseMethod = 4,
-  kConciseGeneratorMethod = kGeneratorFunction | kConciseMethod
+  kConciseGeneratorMethod = kGeneratorFunction | kConciseMethod,
+  kConstructorMethod = kNormalFunction

[Dmitry Lomov (no reviews), 2014/10/07 15:09:37]

Set but unused? Let's remove it.

[arv (Not doing code reviews), 2014/10/07 15:16:52]

It is used in preparser.h. I can change that to use kNormalFunction but I found
that this makes it more clear what is going on.

[Dmitry Lomov (no reviews), 2014/10/07 15:21:05]

Right, I've seen that. Let's not add constants that have no operational meaning
- it is just confusing - one has to look up whether constructor method is
somehow different from normal method.

[arv (Not doing code reviews), 2014/10/07 16:13:18]

Done.

 };
 
 
 inline bool IsValidFunctionKind(FunctionKind kind) {
   return kind == FunctionKind::kNormalFunction ||
          kind == FunctionKind::kArrowFunction ||
          kind == FunctionKind::kGeneratorFunction ||
          kind == FunctionKind::kConciseMethod ||
          kind == FunctionKind::kConciseGeneratorMethod;
 }
@@ skipping 13 matching lines @@
 
 inline bool IsConciseMethod(FunctionKind kind) {
   DCHECK(IsValidFunctionKind(kind));
   return kind & FunctionKind::kConciseMethod;
 }
 } }  // namespace v8::internal
 
 namespace i = v8::internal;
 
 #endif  // V8_GLOBALS_H_