extensions/browser/app_window/app_window.cc - Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/app_window/app_window.cc

diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc

index fedc11d3331f5d084a0d1bf7fe649e0421220b8e..c7990e179848796310266c346858d2ea0e023c42 100644

--- a/extensions/browser/app_window/app_window.cc

+++ b/extensions/browser/app_window/app_window.cc

@@ -282,7 +282,7 @@ void AppWindow::Init(const GURL& url,

AppWindowClient* app_window_client = AppWindowClient::Get();

native_app_window_.reset(

- app_window_client->CreateNativeAppWindow(this, new_params));

+ app_window_client->CreateNativeAppWindow(this, &new_params));

helper_.reset(new AppWebContentsHelper(

browser_context_, extension_id_, web_contents, app_delegate_.get()));

« athena/content/app_activity.cc ('K') | « chrome/browser/ui/apps/chrome_app_window_client.cc ('k') | extensions/browser/app_window/app_window_client.h » ('j') | no next file with comments »