chrome/browser/ui/apps/chrome_app_window_client.cc - Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/apps/chrome_app_window_client.cc

Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/apps/chrome_app_window_client.cc

diff --git a/chrome/browser/ui/apps/chrome_app_window_client.cc b/chrome/browser/ui/apps/chrome_app_window_client.cc

index 829d9704a636276310eb2d455cf85eede9ae8044..fc9eb507add7461f04b238e2c1edbb77b3c87c53 100644

--- a/chrome/browser/ui/apps/chrome_app_window_client.cc

+++ b/chrome/browser/ui/apps/chrome_app_window_client.cc

@@ -44,11 +44,11 @@ extensions::AppWindow* ChromeAppWindowClient::CreateAppWindow(

extensions::NativeAppWindow* ChromeAppWindowClient::CreateNativeAppWindow(

extensions::AppWindow* window,

- const extensions::AppWindow::CreateParams& params) {

+ extensions::AppWindow::CreateParams* params) {

#if defined(OS_ANDROID)

return NULL;

#else

- return CreateNativeAppWindowImpl(window, params);

+ return CreateNativeAppWindowImpl(window, *params);

#endif

}

« athena/content/app_activity.cc ('K') | « chrome/browser/ui/apps/chrome_app_window_client.h ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »