extensions/browser/app_window/app_window_client.h - Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window_client.h

Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed activation Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/extensions/athena_app_window_client_base.cc ('K') | « chrome/browser/ui/apps/chrome_app_window_client.cc ('k') | extensions/browser/extension_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/app_window/app_window_client.h

diff --git a/extensions/browser/app_window/app_window_client.h b/extensions/browser/app_window/app_window_client.h

index a832b23044d37a6a337738f62a94beff88116abc..521c749ae4fc97d8640db57889a9480d362b5ef4 100644

--- a/extensions/browser/app_window/app_window_client.h

+++ b/extensions/browser/app_window/app_window_client.h

@@ -33,7 +33,7 @@ class AppWindowClient {

// Creates a new extensions::NativeAppWindow for |window|.

virtual NativeAppWindow* CreateNativeAppWindow(

AppWindow* window,

- const AppWindow::CreateParams& params) = 0;

+ AppWindow::CreateParams& params) = 0;

oshima 2014/10/08 19:02:31 in_out parameter should be * rather than reference

Mr4D (OOO till 08-26) 2014/10/08 23:48:17 Done.

// Opens DevTools window and runs the callback.

virtual void OpenDevToolsWindow(content::WebContents* web_contents,