Adding application lifetime tests to athena, allowing to override focus request for applciations

extensions/browser/app_window/app_window_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CLIENT_H_
 #define EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CLIENT_H_
 
 #include "base/callback_forward.h"
 #include "extensions/browser/app_window/app_window.h"
 
@@ skipping 15 matching lines @@
   virtual ~AppWindowClient() {}
 
   // Creates a new AppWindow for the app in |extension| for |context|.
   // Caller takes ownership.
   virtual AppWindow* CreateAppWindow(content::BrowserContext* context,
                                      const Extension* extension) = 0;
 
   // Creates a new extensions::NativeAppWindow for |window|.
   virtual NativeAppWindow* CreateNativeAppWindow(
       AppWindow* window,
-      const AppWindow::CreateParams& params) = 0;
+      AppWindow::CreateParams& params) = 0;

[oshima, 2014/10/08 19:02:31]

in_out parameter should be * rather than reference.

[Mr4D (OOO till 08-26), 2014/10/08 23:48:17]

Done.

 
   // Opens DevTools window and runs the callback.
   virtual void OpenDevToolsWindow(content::WebContents* web_contents,
                                   const base::Closure& callback) = 0;
 
   // Returns true if the current channel is older than dev.
   virtual bool IsCurrentChannelOlderThanDev() = 0;
 
   // Return the app window client.
   static AppWindowClient* Get();
 
   // Initialize the app window system with this app window client.
   static void Set(AppWindowClient* client);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CLIENT_H_