chrome/browser/ui/apps/chrome_app_window_client.h - Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/apps/chrome_app_window_client.h

Issue 631333003: Adding application lifetime tests to athena, allowing to override focus request for applciations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed activation Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/extensions/athena_app_window_client_base.cc ('K') | « athena/test/chrome/athena_app_browsertest.h ('k') | chrome/browser/ui/apps/chrome_app_window_client.cc » ('j') | extensions/browser/app_window/app_window_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/apps/chrome_app_window_client.h

diff --git a/chrome/browser/ui/apps/chrome_app_window_client.h b/chrome/browser/ui/apps/chrome_app_window_client.h

index c11d55b107d6f051b43bfd0e8419e0a42bff4026..07dcea7690af79c6b7b2048506da4e5fb6a06e87 100644

--- a/chrome/browser/ui/apps/chrome_app_window_client.h

+++ b/chrome/browser/ui/apps/chrome_app_window_client.h

@@ -30,7 +30,7 @@ class ChromeAppWindowClient : public extensions::AppWindowClient {

const extensions::Extension* extension) override;

virtual extensions::NativeAppWindow* CreateNativeAppWindow(

extensions::AppWindow* window,

- const extensions::AppWindow::CreateParams& params) override;

+ extensions::AppWindow::CreateParams& params) override;

virtual void OpenDevToolsWindow(content::WebContents* web_contents,

const base::Closure& callback) override;

virtual bool IsCurrentChannelOlderThanDev() override;