Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 631113002: Support aria-checked attribute for aria role menuitemcheckbox and menuitemradio (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Support aria-checked attribute for aria role menuitemcheckbox and menuitemradio ARIA role menuitemcheckbox and menuitemradio should support aria-checked attribute. BUG=169569, 420605 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
shreeramk
Please review. Thanks.
6 years, 2 months ago (2014-10-07 10:39:13 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-07 15:38:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631113002/1
6 years, 2 months ago (2014-10-07 15:39:21 UTC) #6
Mike West
LGTM2.
6 years, 2 months ago (2014-10-07 15:40:27 UTC) #7
Mike West
On 2014/10/07 15:40:27, Mike West wrote: > LGTM2. Although it should probably have a bug ...
6 years, 2 months ago (2014-10-07 15:42:26 UTC) #8
shreeramk
On 2014/10/07 15:42:26, Mike West wrote: > On 2014/10/07 15:40:27, Mike West wrote: > > ...
6 years, 2 months ago (2014-10-07 16:08:12 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 16:39:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183351

Powered by Google App Engine
This is Rietveld 408576698