Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 631113002: Support aria-checked attribute for aria role menuitemcheckbox and menuitemradio (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXNodeObject.cpp
diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp
index da26d038230af812a7bc25fe62b37a04317cb11b..9fc3252de8e632584a44a1b6f855fefe3102c080 100644
--- a/Source/core/accessibility/AXNodeObject.cpp
+++ b/Source/core/accessibility/AXNodeObject.cpp
@@ -660,9 +660,11 @@ bool AXNodeObject::isChecked() const
if (isHTMLInputElement(*node))
return toHTMLInputElement(*node).shouldAppearChecked();
- // Else, if this is an ARIA checkbox or radio, respect the aria-checked attribute
+ // Else, if this is an ARIA checkbox or radio OR ARIA role menuitemcheckbox
+ // or menuitemradio, respect the aria-checked attribute
AccessibilityRole ariaRole = ariaRoleAttribute();
- if (ariaRole == RadioButtonRole || ariaRole == CheckBoxRole) {
+ if (ariaRole == RadioButtonRole || ariaRole == CheckBoxRole
+ || ariaRole == MenuItemCheckBoxRole || ariaRole == MenuItemRadioRole) {
if (equalIgnoringCase(getAttribute(aria_checkedAttr), "true"))
return true;
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698