Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 63073002: Increase warning level for windows (Closed)

Created:
7 years, 1 month ago by lgombos
Modified:
7 years, 1 month ago
Reviewers:
Nico, dglazkov, scottmg
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Some of the warnings that are disabled on windows are not actually trigger any failures and can be simply enabled without changing any source code. It is our intent to keep the warning level in blink close to the to the default chromium warning level, so we should re-enable these warnings for windows. BUG=312287 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161685

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/config.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
lgombos
the failures on the try seems to be unrelated..
7 years, 1 month ago (2013-11-06 21:49:19 UTC) #1
dglazkov
lgtm, I believe you.
7 years, 1 month ago (2013-11-06 21:54:30 UTC) #2
Nico
Some of these might be needed for 2012 / 2013 (which the bots don't cover ...
7 years, 1 month ago (2013-11-06 22:06:50 UTC) #3
lgombos
On 2013/11/06 22:06:50, Nico (ooo until Nov 12) wrote: > Some of these might be ...
7 years, 1 month ago (2013-11-06 22:24:12 UTC) #4
scottmg
On 2013/11/06 22:24:12, lgombos wrote: > On 2013/11/06 22:06:50, Nico (ooo until Nov 12) wrote: ...
7 years, 1 month ago (2013-11-06 23:08:05 UTC) #5
lgombos
On 2013/11/06 23:08:05, scottmg wrote: > On 2013/11/06 22:24:12, lgombos wrote: > > On 2013/11/06 ...
7 years, 1 month ago (2013-11-06 23:11:53 UTC) #6
Nico
Now is fine. On Wed, Nov 6, 2013 at 3:11 PM, <l.gombos@samsung.com> wrote: > On ...
7 years, 1 month ago (2013-11-06 23:18:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/63073002/1
7 years, 1 month ago (2013-11-06 23:22:19 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) blink_platform_unittests, webkit_tests, webkit_unit_tests, weborigin_unittests, wtf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=16013
7 years, 1 month ago (2013-11-07 01:50:31 UTC) #9
lgombos
Dependent patch reverted.. will need to wait with this a bit more.. https://codereview.chromium.org/61733005
7 years, 1 month ago (2013-11-07 02:30:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/63073002/240001
7 years, 1 month ago (2013-11-09 06:17:52 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 07:35:02 UTC) #12
Message was sent while issue was closed.
Change committed as 161685

Powered by Google App Engine
This is Rietveld 408576698