Issue 61733005: Revert 161469 "Enable chromium_code=1 on Windows"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61733005: Revert 161469 "Enable chromium_code=1 on Windows" (Closed)

Created:
7 years, 1 month ago by Ken Russell (switch to Gerrit)

Modified:
7 years, 1 month ago

Reviewers:
scottmg

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 161469 "Enable chromium_code=1 on Windows" Seems to be the cause of Windows x64 build breakage, preventing Blink rolls. > Enable chromium_code=1 on Windows > > TBR=dglazkov@chromium.org > R=thakis@chromium.org > BUG=312287 > > Review URL: https://codereview.chromium.org/60113005 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161482

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -15 lines)			Patch
M	trunk/Source/config.gyp	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	trunk/Source/core/dom/shadow/ShadowRoot.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/Source/core/fetch/Resource.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/core/rendering/ClipRect.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/core/rendering/RenderLayer.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/Source/core/rendering/RenderLayerScrollableArea.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/core/rendering/RenderLayerStackingNode.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/Source/core/rendering/RenderView.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/platform/text/LocaleWin.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Ken Russell (switch to Gerrit)

7 years, 1 month ago (2013-11-07 01:25:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r161482.