Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: tools/gn/label_pattern_unittest.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/label_pattern_unittest.cc
diff --git a/tools/gn/label_pattern_unittest.cc b/tools/gn/label_pattern_unittest.cc
index 21d6a9b12149f39cea41864b06e8ec1f697f1b74..2d9eca60e58b40df6940c2929314ff6fa636450e 100644
--- a/tools/gn/label_pattern_unittest.cc
+++ b/tools/gn/label_pattern_unittest.cc
@@ -62,7 +62,6 @@ TEST(LabelPattern, PatternParse) {
Err err;
LabelPattern result =
LabelPattern::GetPattern(current_dir, Value(NULL, cur.input), &err);
-
brettw 2014/11/05 19:59:49 Revert this file.
zeuthen 2014/11/07 19:24:12 Done.
EXPECT_EQ(cur.success, !err.has_error()) << i << " " << cur.input;
EXPECT_EQ(cur.type, result.type()) << i << " " << cur.input;
EXPECT_EQ(cur.dir, result.dir().value()) << i << " " << cur.input;

Powered by Google App Engine
This is Rietveld 408576698