tools/gn/ninja_action_target_writer.cc - Issue 630223002: gn: Support build directories outside the source tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_action_target_writer.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated patch set Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_action_target_writer.cc

diff --git a/tools/gn/ninja_action_target_writer.cc b/tools/gn/ninja_action_target_writer.cc

index 25c86337a9f29724fff22136c8a040a1f2bd3e27..84ec0723c6e3821da4af29ad0da7f459174edcaf 100644

--- a/tools/gn/ninja_action_target_writer.cc

+++ b/tools/gn/ninja_action_target_writer.cc

@@ -17,6 +17,7 @@ NinjaActionTargetWriter::NinjaActionTargetWriter(const Target* target,

: NinjaTargetWriter(target, out),

path_output_no_escaping_(

target->settings()->build_settings()->build_dir(),

+ target->settings()->build_settings()->root_path_utf8(),

ESCAPE_NONE) {

}

« tools/gn/label_pattern_unittest.cc ('K') | « tools/gn/label_pattern_unittest.cc ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | tools/gn/path_output.cc » ('J')