Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/gn/build_settings.h

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/build_settings.h
diff --git a/tools/gn/build_settings.h b/tools/gn/build_settings.h
index daea82dd2278919366bf313e4f63bb1c48c5f18f..33e454ba48e827a18098c6d6f8c3c23804456b7a 100644
--- a/tools/gn/build_settings.h
+++ b/tools/gn/build_settings.h
@@ -57,12 +57,6 @@ class BuildSettings {
const SourceDir& build_dir() const { return build_dir_; }
void SetBuildDir(const SourceDir& dir);
- // The inverse of relative_build_dir, ending with a separator.
- // Example: relative_build_dir_ = "out/Debug/" this will be "../../"
- const std::string& build_to_source_dir_string() const {
- return build_to_source_dir_string_;
- }
-
// The build args are normally specified on the command-line.
Args& build_args() { return build_args_; }
const Args& build_args() const { return build_args_; }
@@ -99,7 +93,6 @@ class BuildSettings {
SourceFile build_config_file_;
SourceDir build_dir_;
- std::string build_to_source_dir_string_;
Args build_args_;
ItemDefinedCallback item_defined_callback_;

Powered by Google App Engine
This is Rietveld 408576698