Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/gn/action_target_generator.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/build_settings.h » ('j') | tools/gn/filesystem_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/action_target_generator.cc
diff --git a/tools/gn/action_target_generator.cc b/tools/gn/action_target_generator.cc
index 793635937b9ea15576fcffe069607ad6f41f1f19..09c89e4ca949b5c36e11b883ef665a6b5297351c 100644
--- a/tools/gn/action_target_generator.cc
+++ b/tools/gn/action_target_generator.cc
@@ -73,7 +73,8 @@ bool ActionTargetGenerator::FillScript() {
return false;
SourceFile script_file =
- scope_->GetSourceDir().ResolveRelativeFile(value->string_value());
+ scope_->GetSourceDir().ResolveRelativeFile(value->string_value(),
+ scope_->settings()->build_settings()->root_path_utf8());
if (script_file.value().empty()) {
*err_ = Err(*value, "script name is empty");
return false;
« no previous file with comments | « no previous file | tools/gn/build_settings.h » ('j') | tools/gn/filesystem_utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698