Roll Clang 217949:218707 (+r218742 and r218921)

tools/clang/plugins/CMakeLists.txt

Index: tools/clang/plugins/CMakeLists.txt
diff --git a/tools/clang/plugins/CMakeLists.txt b/tools/clang/plugins/CMakeLists.txt
index 7dcdb4884184ab4dd1fabe0383c6f650d3517aee..d17de19fcd09d79a5a41860469a9dd97a557f29a 100644
--- a/tools/clang/plugins/CMakeLists.txt
+++ b/tools/clang/plugins/CMakeLists.txt
@@ -4,6 +4,8 @@ add_llvm_loadable_module(libFindBadConstructs
                          FindBadConstructsConsumer.cpp
                         )
 
+add_dependencies(libFindBadConstructs clang)

[Nico, 2014/10/11 01:04:57]

why these changes?

[hans, 2014/10/11 04:31:46]

https://codereview.chromium.org/615083006/, which makes us build the tools and
plugins in-tree doesn't add a dependency edge from the plugins to clang. So the
build would fail if e.g. generated sources (like Attrs.inc) in clang aren't
built when the plugin builds.

This makes it build for the time being, but it's not very nice. Maybe we need to
go back to copying the files into the tree :/

+
 cr_install(TARGETS libFindBadConstructs LIBRARY DESTINATION lib)
 
 cr_add_test(plugins_test