tools/clang/plugins/CMakeLists.txt - Issue 630163005: Roll Clang 217949:218707 (+r218742 and r218921)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/CMakeLists.txt

Issue 630163005: Roll Clang 217949:218707 (+r218742 and r218921) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 add_llvm_loadable_module(libFindBadConstructs	1 add_llvm_loadable_module(libFindBadConstructs

2 ChromeClassTester.cpp	2 ChromeClassTester.cpp

3 FindBadConstructsAction.cpp	3 FindBadConstructsAction.cpp

4 FindBadConstructsConsumer.cpp	4 FindBadConstructsConsumer.cpp

5 )	5 )

6	6

	7 add_dependencies(libFindBadConstructs clang)
	Nico 2014/10/11 01:04:57 why these changes? why these changes? hans 2014/10/11 04:31:46 https://codereview.chromium.org/615083006/, which Show quoted text On 2014/10/11 01:04:57, Nico (away until Oct 27) wrote: > why these changes? https://codereview.chromium.org/615083006/, which makes us build the tools and plugins in-tree doesn't add a dependency edge from the plugins to clang. So the build would fail if e.g. generated sources (like Attrs.inc) in clang aren't built when the plugin builds. This makes it build for the time being, but it's not very nice. Maybe we need to go back to copying the files into the tree :/
	8

7 cr_install(TARGETS libFindBadConstructs LIBRARY DESTINATION lib)	9 cr_install(TARGETS libFindBadConstructs LIBRARY DESTINATION lib)

8	10

9 cr_add_test(plugins_test	11 cr_add_test(plugins_test

10 ${CMAKE_CURRENT_SOURCE_DIR}/tests/test.sh	12 ${CMAKE_CURRENT_SOURCE_DIR}/tests/test.sh

11 ${CMAKE_BINARY_DIR}/bin/clang	13 ${CMAKE_BINARY_DIR}/bin/clang

12 $<TARGET_FILE:libFindBadConstructs>	14 $<TARGET_FILE:libFindBadConstructs>

13 )	15 )

OLD	NEW