[Android] Do not warm up access to the profile directory in isolated services.

[Android] Do not warm up access to the profile directory in isolated services.

This is motivated by a change in the SELinux policies for isolated services:
https://android-review.googlesource.com/#/c/109577/

Committed: https://crrev.com/cb03e2e2687edcd5f43269d513c62fba5751a926
Cr-Commit-Position: refs/heads/master@{#298855}

[Robert Sesek, 2014-10-07 17:47:56]

rsesek@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Robert Sesek, 2014-10-07 17:49:05]

dtrainor: You added this file initially, are you the best reviewer for this CL?

[Robert Sesek, 2014-10-08 17:24:30]

dtrainor: ping

[David Trainor- moved to gerrit, 2014-10-08 17:33:13]

lgtm sorry for the delay!

[Robert Sesek, 2014-10-08 17:44:34]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-10-08 17:45:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/630123003/1

[Robert Sesek, 2014-10-08 17:51:06]

rsesek@chromium.org changed reviewers:
+ jochen@chromium.org

[Robert Sesek, 2014-10-08 17:51:06]

+jochen for OWNERS stamp

[commit-bot: I haz the power, 2014-10-08 17:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-08 17:53:48]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jochen (gone - plz use gerrit), 2014-10-09 11:29:52]

lgtm

[Robert Sesek, 2014-10-09 12:38:36]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-10-09 12:39:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/630123003/1

[commit-bot: I haz the power, 2014-10-09 12:45:41]

Committed patchset #1 (id:1) as ff947eff605b5e5b55edd2d390e91b2f4efddef5

[commit-bot: I haz the power, 2014-10-09 12:46:28]

Patchset 1 (id:??) landed as
https://crrev.com/cb03e2e2687edcd5f43269d513c62fba5751a926
Cr-Commit-Position: refs/heads/master@{#298855}

[klobag.chromium, 2014-10-17 17:41:13]

klobag@chromium.org changed reviewers:
+ klobag@chromium.org

[klobag.chromium, 2014-10-17 17:41:14]

https://codereview.chromium.org/630123003/diff/1/chrome/common/chrome_paths_a...
File chrome/common/chrome_paths_android.cc (right):

https://codereview.chromium.org/630123003/diff/1/chrome/common/chrome_paths_a...
chrome/common/chrome_paths_android.cc:55: if (process_type ==
switches::kRendererProcess)
How about the other child process type?

Should we check empty string for process_type to ensure it only returns true for
browser process?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...

[Robert Sesek, 2014-10-17 18:00:32]

https://codereview.chromium.org/630123003/diff/1/chrome/common/chrome_paths_a...
File chrome/common/chrome_paths_android.cc (right):

https://codereview.chromium.org/630123003/diff/1/chrome/common/chrome_paths_a...
chrome/common/chrome_paths_android.cc:55: if (process_type ==
switches::kRendererProcess)
On 2014/10/17 17:41:14, klobag.chromium wrote:
> How about the other child process type?
> 
> Should we check empty string for process_type to ensure it only returns true
for
> browser process?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...

I wanted to keep the change scoped small, since I wasn't sure what other process
types Chrome used. Would you prefer to only return true if process_type.empty()
to match the CHECK? If so, I'll put together a CL to do that.

[klobag.chromium, 2014-10-17 18:34:55]

Please make this return true for empty string only. All the child processes are
created as isolated services on Android, including renderer, utility and soon
GPU.