[Android] Do not warm up access to the profile directory in isolated services.

chrome/common/chrome_paths_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_paths_internal.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
+#include "content/public/common/content_switches.h"
 
 namespace chrome {
 
 void GetUserCacheDirectory(const base::FilePath& profile_dir,
                            base::FilePath* result) {
   if (!PathService::Get(base::DIR_CACHE, result))
     *result = profile_dir;
 }
 
 bool GetDefaultUserDataDirectory(base::FilePath* result) {
@@ skipping 23 matching lines @@
   NOTIMPLEMENTED();
   return false;
 }
 
 bool GetUserVideosDirectory(base::FilePath* result) {
   NOTIMPLEMENTED();
   return false;
 }
 
 bool ProcessNeedsProfileDir(const std::string& process_type) {
+  // SELinux prohibits accessing the data directory for isolated services.
+  if (process_type == switches::kRendererProcess)

[klobag.chromium, 2014/10/17 17:41:14]

How about the other child process type?

Should we check empty string for process_type to ensure it only returns true for
browser process?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_...

[Robert Sesek, 2014/10/17 18:00:32]

I wanted to keep the change scoped small, since I wasn't sure what other process
types Chrome used. Would you prefer to only return true if process_type.empty()
to match the CHECK? If so, I'll put together a CL to do that.

+    return false;
+
   return true;
 }
 
 }  // namespace chrome