Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 630093005: Move paint code from RootInlineBox and EllipsisBox to RootInlineBoxPainter and EllipsisBoxPainter. (Closed)

Created:
6 years, 2 months ago by chrishtr
Modified:
6 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move paint code from RootInlineBox and EllipsisBox to RootInlineBoxPainter and EllipsisBoxPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -81 lines) Patch
M Source/core/core.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
A Source/core/paint/EllipsisBoxPainter.h View 1 chunk +35 lines, -0 lines 0 comments Download
A Source/core/paint/EllipsisBoxPainter.cpp View 1 chunk +87 lines, -0 lines 0 comments Download
A Source/core/paint/RootInlineBoxPainter.h View 1 chunk +29 lines, -0 lines 0 comments Download
A Source/core/paint/RootInlineBoxPainter.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/rendering/EllipsisBox.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/EllipsisBox.cpp View 3 chunks +2 lines, -67 lines 0 comments Download
M Source/core/rendering/RootInlineBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
chrishtr
6 years, 2 months ago (2014-10-07 20:21:41 UTC) #2
pdr.
On 2014/10/07 at 20:21:41, chrishtr wrote: > LGTM
6 years, 2 months ago (2014-10-07 20:25:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630093005/1
6 years, 2 months ago (2014-10-07 20:26:31 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 00:02:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183369

Powered by Google App Engine
This is Rietveld 408576698