Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: Source/core/rendering/RootInlineBox.cpp

Issue 630093005: Move paint code from RootInlineBox and EllipsisBox to RootInlineBoxPainter and EllipsisBoxPainter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RootInlineBox.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details. 12 * Library General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU Library General Public License 14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to 15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA. 17 * Boston, MA 02110-1301, USA.
18 */ 18 */
19 19
20 #include "config.h" 20 #include "config.h"
21 #include "core/rendering/RootInlineBox.h" 21 #include "core/rendering/RootInlineBox.h"
22 22
23 #include "core/dom/Document.h" 23 #include "core/dom/Document.h"
24 #include "core/dom/StyleEngine.h" 24 #include "core/dom/StyleEngine.h"
25 #include "core/paint/RootInlineBoxPainter.h"
25 #include "core/rendering/EllipsisBox.h" 26 #include "core/rendering/EllipsisBox.h"
26 #include "core/rendering/HitTestResult.h" 27 #include "core/rendering/HitTestResult.h"
27 #include "core/rendering/InlineTextBox.h" 28 #include "core/rendering/InlineTextBox.h"
28 #include "core/rendering/PaintInfo.h" 29 #include "core/rendering/PaintInfo.h"
29 #include "core/rendering/RenderBlockFlow.h" 30 #include "core/rendering/RenderBlockFlow.h"
30 #include "core/rendering/RenderFlowThread.h" 31 #include "core/rendering/RenderFlowThread.h"
31 #include "core/rendering/RenderInline.h" 32 #include "core/rendering/RenderInline.h"
32 #include "core/rendering/RenderView.h" 33 #include "core/rendering/RenderView.h"
33 #include "core/rendering/VerticalPositionCache.h" 34 #include "core/rendering/VerticalPositionCache.h"
34 #include "platform/text/BidiResolver.h" 35 #include "platform/text/BidiResolver.h"
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 float RootInlineBox::placeEllipsisBox(bool ltr, float blockLeftEdge, float block RightEdge, float ellipsisWidth, float &truncatedWidth, bool& foundBox) 145 float RootInlineBox::placeEllipsisBox(bool ltr, float blockLeftEdge, float block RightEdge, float ellipsisWidth, float &truncatedWidth, bool& foundBox)
145 { 146 {
146 float result = InlineFlowBox::placeEllipsisBox(ltr, blockLeftEdge, blockRigh tEdge, ellipsisWidth, truncatedWidth, foundBox); 147 float result = InlineFlowBox::placeEllipsisBox(ltr, blockLeftEdge, blockRigh tEdge, ellipsisWidth, truncatedWidth, foundBox);
147 if (result == -1) { 148 if (result == -1) {
148 result = ltr ? blockRightEdge - ellipsisWidth : blockLeftEdge; 149 result = ltr ? blockRightEdge - ellipsisWidth : blockLeftEdge;
149 truncatedWidth = blockRightEdge - blockLeftEdge; 150 truncatedWidth = blockRightEdge - blockLeftEdge;
150 } 151 }
151 return result; 152 return result;
152 } 153 }
153 154
154 void RootInlineBox::paintEllipsisBox(PaintInfo& paintInfo, const LayoutPoint& pa intOffset, LayoutUnit lineTop, LayoutUnit lineBottom) const
155 {
156 if (hasEllipsisBox() && paintInfo.shouldPaintWithinRoot(&renderer()) && rend erer().style()->visibility() == VISIBLE
157 && paintInfo.phase == PaintPhaseForeground)
158 ellipsisBox()->paint(paintInfo, paintOffset, lineTop, lineBottom);
159 }
160
161 void RootInlineBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, LayoutUnit lineTop, LayoutUnit lineBottom) 155 void RootInlineBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, LayoutUnit lineTop, LayoutUnit lineBottom)
162 { 156 {
163 InlineFlowBox::paint(paintInfo, paintOffset, lineTop, lineBottom); 157 RootInlineBoxPainter(*this).paint(paintInfo, paintOffset, lineTop, lineBotto m);
164 paintEllipsisBox(paintInfo, paintOffset, lineTop, lineBottom);
165 } 158 }
166 159
167 bool RootInlineBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& re sult, const HitTestLocation& locationInContainer, const LayoutPoint& accumulated Offset, LayoutUnit lineTop, LayoutUnit lineBottom) 160 bool RootInlineBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& re sult, const HitTestLocation& locationInContainer, const LayoutPoint& accumulated Offset, LayoutUnit lineTop, LayoutUnit lineBottom)
168 { 161 {
169 if (hasEllipsisBox() && visibleToHitTestRequest(request)) { 162 if (hasEllipsisBox() && visibleToHitTestRequest(request)) {
170 if (ellipsisBox()->nodeAtPoint(request, result, locationInContainer, acc umulatedOffset, lineTop, lineBottom)) { 163 if (ellipsisBox()->nodeAtPoint(request, result, locationInContainer, acc umulatedOffset, lineTop, lineBottom)) {
171 renderer().updateHitTestResult(result, locationInContainer.point() - toLayoutSize(accumulatedOffset)); 164 renderer().updateHitTestResult(result, locationInContainer.point() - toLayoutSize(accumulatedOffset));
172 return true; 165 return true;
173 } 166 }
174 } 167 }
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
865 } 858 }
866 859
867 #ifndef NDEBUG 860 #ifndef NDEBUG
868 const char* RootInlineBox::boxName() const 861 const char* RootInlineBox::boxName() const
869 { 862 {
870 return "RootInlineBox"; 863 return "RootInlineBox";
871 } 864 }
872 #endif 865 #endif
873 866
874 } // namespace blink 867 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RootInlineBox.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698