Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 630063002: Make createOptDrawState return NULL if we would end up not drawing (Closed)

Created:
6 years, 2 months ago by egdaniel
Modified:
6 years, 2 months ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make createOptDrawState return NULL if we would end up not drawing BUG=skia: Committed: https://skia.googlesource.com/skia/+/b109ac22b4ec3ab3478f5304c96564a0e9df6170

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Move create opt state to GrOptDrawState #

Patch Set 4 : Clean up #

Total comments: 3

Patch Set 5 : Rebase and Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -38 lines) Patch
M src/gpu/GrDrawState.h View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 2 3 3 chunks +18 lines, -2 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 2 3 4 2 chunks +36 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 3 4 2 chunks +14 lines, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
egdaniel
This change will make it so that if we don't end up doing a draw, ...
6 years, 2 months ago (2014-10-06 20:35:48 UTC) #3
bsalomon
lgtm https://codereview.chromium.org/630063002/diff/80001/src/gpu/gl/GrGpuGL_program.cpp File src/gpu/gl/GrGpuGL_program.cpp (right): https://codereview.chromium.org/630063002/diff/80001/src/gpu/gl/GrGpuGL_program.cpp#newcode213 src/gpu/gl/GrGpuGL_program.cpp:213: if (NULL == optState.get()) { howabout if (!optState) ...
6 years, 2 months ago (2014-10-06 20:40:20 UTC) #4
joshua.litt
lgtm https://codereview.chromium.org/630063002/diff/80001/src/gpu/GrOptDrawState.cpp File src/gpu/GrOptDrawState.cpp (right): https://codereview.chromium.org/630063002/diff/80001/src/gpu/GrOptDrawState.cpp#newcode63 src/gpu/GrOptDrawState.cpp:63: if (kZero_GrBlendCoeff == srcCoeff && kOne_GrBlendCoeff == dstCoeff ...
6 years, 2 months ago (2014-10-06 20:40:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630063002/100001
6 years, 2 months ago (2014-10-07 13:30:26 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 13:45:48 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:100001) as b109ac22b4ec3ab3478f5304c96564a0e9df6170

Powered by Google App Engine
This is Rietveld 408576698