tests/GLProgramsTest.cpp - Issue 630063002: Make createOptDrawState return NULL if we would end up not drawing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/GLProgramsTest.cpp

Issue 630063002: Make createOptDrawState return NULL if we would end up not drawing (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rebase and Nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/GLProgramsTest.cpp

diff --git a/tests/GLProgramsTest.cpp b/tests/GLProgramsTest.cpp

index a0d642741e1ff23b3bcacb313fd2c5f2d30e6a2d..d8ce3fdc9ff4d312b7ef5292692f10ddca199ce3 100644

--- a/tests/GLProgramsTest.cpp

+++ b/tests/GLProgramsTest.cpp

@@ -332,7 +332,9 @@ bool GrGpuGL::programUnitTest(int maxStages) {

return false;

}

- SkAutoTUnref<GrOptDrawState> optState(this->getDrawState().createOptState(*this->caps()));

+ SkAutoTUnref<GrOptDrawState> optState(GrOptDrawState::Create(this->getDrawState(),

+ *this->caps(),

+ drawType));

SkAutoTUnref<GrGLProgram> program(GrGLProgram::Create(this,

*optState.get(),

pdesc,

« no previous file with comments | « src/gpu/gl/GrGpuGL_program.cpp ('k') | no next file » | no next file with comments »