Issue 630023002: Remove FLAG_opt_safe_uint32_operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 630023002: Remove FLAG_opt_safe_uint32_operations. (Closed)

Created:
6 years, 2 months ago by Jakob Kummerow

Modified:
6 years, 2 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Remove FLAG_opt_safe_uint32_operations. It has been turned on by default for a long time, and hydrogenized BinaryOpStubs actually depend on it being turned on. BUG=v8:3487 LOG=n R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24415

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -49 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/arm64/lithium-arm64.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/mips64/lithium-mips64.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/x87/lithium-x87.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	test/mjsunit/compiler/shift-shr.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

Jakob Kummerow

6 years, 2 months ago (2014-10-06 13:15:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24415 (presubmit successful).