Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 630023002: Remove FLAG_opt_safe_uint32_operations. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips64/lithium-mips64.cc ('k') | src/x87/lithium-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_X64 9 #if V8_TARGET_ARCH_X64
10 10
(...skipping 704 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 // cannot be truncated to smi. 715 // cannot be truncated to smi.
716 does_deopt = !instr->CheckUsesForFlag(HValue::kTruncatingToSmi); 716 does_deopt = !instr->CheckUsesForFlag(HValue::kTruncatingToSmi);
717 } 717 }
718 } else { 718 } else {
719 right = UseFixed(right_value, rcx); 719 right = UseFixed(right_value, rcx);
720 } 720 }
721 721
722 // Shift operations can only deoptimize if we do a logical shift by 0 and 722 // Shift operations can only deoptimize if we do a logical shift by 0 and
723 // the result cannot be truncated to int32. 723 // the result cannot be truncated to int32.
724 if (op == Token::SHR && constant_value == 0) { 724 if (op == Token::SHR && constant_value == 0) {
725 if (FLAG_opt_safe_uint32_operations) { 725 does_deopt = !instr->CheckFlag(HInstruction::kUint32);
726 does_deopt = !instr->CheckFlag(HInstruction::kUint32);
727 } else {
728 does_deopt = !instr->CheckUsesForFlag(HValue::kTruncatingToInt32);
729 }
730 } 726 }
731 727
732 LInstruction* result = 728 LInstruction* result =
733 DefineSameAsFirst(new(zone()) LShiftI(op, left, right, does_deopt)); 729 DefineSameAsFirst(new(zone()) LShiftI(op, left, right, does_deopt));
734 return does_deopt ? AssignEnvironment(result) : result; 730 return does_deopt ? AssignEnvironment(result) : result;
735 } else { 731 } else {
736 return DoArithmeticT(op, instr); 732 return DoArithmeticT(op, instr);
737 } 733 }
738 } 734 }
739 735
(...skipping 1946 matching lines...) Expand 10 before | Expand all | Expand 10 after
2686 LOperand* function = UseRegisterAtStart(instr->function()); 2682 LOperand* function = UseRegisterAtStart(instr->function());
2687 LAllocateBlockContext* result = 2683 LAllocateBlockContext* result =
2688 new(zone()) LAllocateBlockContext(context, function); 2684 new(zone()) LAllocateBlockContext(context, function);
2689 return MarkAsCall(DefineFixed(result, rsi), instr); 2685 return MarkAsCall(DefineFixed(result, rsi), instr);
2690 } 2686 }
2691 2687
2692 2688
2693 } } // namespace v8::internal 2689 } } // namespace v8::internal
2694 2690
2695 #endif // V8_TARGET_ARCH_X64 2691 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips64/lithium-mips64.cc ('k') | src/x87/lithium-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698