Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

Issue 629583002: Make compositor and blink talk in fractional scroll offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/ScrollingCoordinatorChromiumTest.cpp
diff --git a/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp b/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp
index c6d46af9f77c5ab0a038a45046e86eae63239205..d5e412a5d29e90f67bc70e9a7cfd14a7e26885a4 100644
--- a/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp
+++ b/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp
@@ -462,7 +462,7 @@ TEST_F(ScrollingCoordinatorChromiumTest, rtlIframe)
ASSERT_TRUE(webScrollLayer->scrollable());
int expectedScrollPosition = 958 + (innerFrameView->verticalScrollbar()->isOverlayScrollbar() ? 0 : 15);
Rick Byers 2014/10/04 00:04:25 again, let's use a non-integer value
Yufeng Shen (Slow to review) 2014/10/06 17:54:58 hmm, not sure about this one. This test is testing
Rick Byers 2014/10/06 21:11:30 Ah, I hadn't looked that deeply. Looks fine - tha
- ASSERT_EQ(expectedScrollPosition, webScrollLayer->scrollPosition().x);
+ ASSERT_EQ(expectedScrollPosition, webScrollLayer->scrollPositionDouble().x);
}
TEST_F(ScrollingCoordinatorChromiumTest, setupScrollbarLayerShouldNotCrash)

Powered by Google App Engine
This is Rietveld 408576698