Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 62953014: ARM and MIPS changes which correspond to the initial change submitted in (Closed)

Created:
7 years, 1 month ago by siva
Modified:
7 years, 1 month ago
Reviewers:
zra, regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

ARM and MIPS changes which correspond to the initial change submitted in https://codereview.chromium.org/63093003/ R=regis@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=30124

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -105 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M runtime/vm/assembler_mips.h View 2 chunks +14 lines, -3 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 2 chunks +38 lines, -50 lines 0 comments Download
M runtime/vm/stack_frame_arm.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame_mips.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 10 chunks +15 lines, -9 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 13 chunks +18 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 1 month ago (2013-11-08 18:50:02 UTC) #1
zra
lgtm
7 years, 1 month ago (2013-11-08 19:03:50 UTC) #2
regis
LGTM
7 years, 1 month ago (2013-11-08 19:10:19 UTC) #3
siva
7 years, 1 month ago (2013-11-08 19:40:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r30124 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698