Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 62953003: Support removal of DRI platform (Closed)

Created:
7 years, 1 month ago by spang
Modified:
7 years, 1 month ago
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

Support removal of DRI platform All ozone configurations currently build DRI support, and therefore have a dependency on the libdrm system library. This is not needed except when ozone_platform_dri is enabled. This allows us to drop the link to libdrm when it is not needed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233671

Patch Set 1 #

Patch Set 2 : fix use_ozone=0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2267 lines) Patch
M build/common.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M build/filename_rules.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 chunks +11 lines, -11 lines 0 comments Download
A + ui/gfx/ozone/dri/dri_skbitmap.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/ozone/dri/dri_skbitmap.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/ozone/dri/dri_surface.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/ozone/dri/dri_surface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/ozone/dri/dri_surface_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/ozone/dri/dri_surface_factory.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/ozone/dri/dri_surface_factory_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + ui/gfx/ozone/dri/dri_surface_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/gfx/ozone/dri/dri_wrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/ozone/dri/dri_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/ozone/dri/hardware_display_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/ozone/dri/hardware_display_controller.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + ui/gfx/ozone/dri/hardware_display_controller_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
D ui/gfx/ozone/impl/dri_skbitmap.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/gfx/ozone/impl/dri_skbitmap.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D ui/gfx/ozone/impl/dri_surface.h View 1 chunk +0 lines, -167 lines 0 comments Download
D ui/gfx/ozone/impl/dri_surface.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D ui/gfx/ozone/impl/dri_surface_factory.h View 1 chunk +0 lines, -76 lines 0 comments Download
D ui/gfx/ozone/impl/dri_surface_factory.cc View 1 chunk +0 lines, -315 lines 0 comments Download
D ui/gfx/ozone/impl/dri_surface_factory_unittest.cc View 1 chunk +0 lines, -292 lines 0 comments Download
D ui/gfx/ozone/impl/dri_surface_unittest.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D ui/gfx/ozone/impl/dri_wrapper.h View 1 chunk +0 lines, -85 lines 0 comments Download
D ui/gfx/ozone/impl/dri_wrapper.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D ui/gfx/ozone/impl/hardware_display_controller.h View 1 chunk +0 lines, -173 lines 0 comments Download
D ui/gfx/ozone/impl/hardware_display_controller.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D ui/gfx/ozone/impl/hardware_display_controller_unittest.cc View 1 chunk +0 lines, -301 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_unittests.gyp View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
spang
7 years, 1 month ago (2013-11-06 20:34:08 UTC) #1
dnicoara
lgtm
7 years, 1 month ago (2013-11-06 21:19:04 UTC) #2
rjkroege
lgtm awesome!
7 years, 1 month ago (2013-11-06 21:25:04 UTC) #3
vignatti (out of this project)
On 2013/11/06 21:25:04, rjkroege wrote: > lgtm > > awesome! I was already wondering about ...
7 years, 1 month ago (2013-11-06 23:10:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/62953003/1
7 years, 1 month ago (2013-11-06 23:14:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=93366
7 years, 1 month ago (2013-11-07 00:20:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/62953003/1
7 years, 1 month ago (2013-11-07 06:39:46 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=120510
7 years, 1 month ago (2013-11-07 06:56:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/62953003/670001
7 years, 1 month ago (2013-11-07 14:54:03 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 20:10:47 UTC) #10
Message was sent while issue was closed. 
Change committed as 233671

Powered by Google App Engine
This is Rietveld 408576698