Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 629183002: Replacing the OVERRIDE with override and FINAL with final in content/browser/android (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/android This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/2d604b12e67e2b76a74d5faa640e3c8aba04da35 Cr-Commit-Position: refs/heads/master@{#298249}

Patch Set 1 #

Patch Set 2 : Resolving Error in android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -148 lines) Patch
M content/browser/android/composited_touch_handle_drawable.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/android/content_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.h View 2 chunks +13 lines, -13 lines 0 comments Download
M content/browser/android/content_view_render_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/content_view_render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_statics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/download_controller_android_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/android/edge_effect.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/android/edge_effect_l.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.h View 1 chunk +15 lines, -15 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/android/interstitial_page_delegate_android.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/android/java/gin_java_bound_object_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/android/java/gin_java_bridge_dispatcher_host.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/java/gin_java_method_invocation_helper_unittest.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M content/browser/android/popup_touch_handle_drawable.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/android/surface_texture_peer_browser_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/system_ui_resource_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/system_ui_resource_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/system_ui_resource_manager_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/android/ui_resource_provider_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/android/web_contents_observer_android.h View 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 13:03:41 UTC) #2
Avi (use Gerrit)
On 2014/10/06 13:03:41, MRV wrote: > PTAL Stampity stamp LGTM
6 years, 2 months ago (2014-10-06 15:00:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629183002/20001
6 years, 2 months ago (2014-10-06 15:43:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as be2f0fffcb39178021687ec2f90e9e6831a32bdf
6 years, 2 months ago (2014-10-06 16:36:03 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 16:36:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d604b12e67e2b76a74d5faa640e3c8aba04da35
Cr-Commit-Position: refs/heads/master@{#298249}

Powered by Google App Engine
This is Rietveld 408576698