IA2 role is not correct for input type attribute in button & checkbox state with aria-role menu as …

IA2 role is not correct for input type attribute in button & checkbox state with aria-role menu as parent.

According to latest editor draft(http://rawgit.com/w3c/html-api-map/master/index.html)

For input type attribute in button state with aria role menu as parent, IA2 role
should be ROLE_SYSTEM_MENUITEM and in checkbox state with aria-role menu as parent,
IA2 role should be IA2_ROLE_CHECK_MENU_ITEM.

This is continuation of this CL https://codereview.chromium.org/589383004/ where the case for aria-role menu was missed.
BUG=169574
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183314

[shreeramk, 2014-10-06 12:20:51]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2014-10-06 12:20:51]

Please review.

Thanks

[shreeramk, 2014-10-06 12:21:05]

shreeram.k@samsung.com changed reviewers:
+ aboxhall@chromium.org

[dmazzoni, 2014-10-06 15:25:43]

lgtm with one nit

no need to request re-review after making that one fix, go ahead and cq

https://codereview.chromium.org/629173002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/629173002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXNodeObject.cpp:207: if (node()->parentNode() &&
(isHTMLMenuElement(node()->parentNode()) || parentObject()->roleValue() ==
MenuRole))
It's possible parentObject() could return null, so you should check that too

[shreeramk, 2014-10-07 06:56:01]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-10-07 06:56:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/629173002/20001

[commit-bot: I haz the power, 2014-10-07 08:04:06]

Committed patchset #2 (id:20001) as 183314