Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 629173002: IA2 role is not correct for input type attribute in button & checkbox state with aria-role menu as … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixing nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXNodeObject.cpp
diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp
index 28f096c7cddb160b66987da39743d3398478b60f..571e5a23f8e60a296b5f025906ec007ad255bcc6 100644
--- a/Source/core/accessibility/AXNodeObject.cpp
+++ b/Source/core/accessibility/AXNodeObject.cpp
@@ -204,12 +204,12 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()
HTMLInputElement& input = toHTMLInputElement(*node());
const AtomicString& type = input.type();
if (type == InputTypeNames::button) {
- if (node()->parentNode() && isHTMLMenuElement(node()->parentNode()))
+ if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))
return MenuItemRole;
return buttonRoleType();
}
if (type == InputTypeNames::checkbox) {
- if (node()->parentNode() && isHTMLMenuElement(node()->parentNode()))
+ if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))
return CheckBoxMenuItemRole;
return CheckBoxRole;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698