Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 629143003: Replace OVERRIDE and FINAL with override and final in content/shell/[a-s]* (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, Michael van Ouwerkerk, jam, yurys, mkwst+moarreviews-ipc_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/shell/[a-s]* BUG=417463 Committed: https://crrev.com/449f39a4f8db61782b697e3bacf541416ed13b1e Cr-Commit-Position: refs/heads/master@{#298227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -367 lines) Patch
M content/shell/browser/ipc_echo_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/notify_done_forwarder.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell.h View 2 chunks +20 lines, -20 lines 0 comments Download
M content/shell/browser/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 chunk +13 lines, -13 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 chunk +20 lines, -20 lines 0 comments Download
M content/shell/browser/shell_devtools_delegate.h View 2 chunks +10 lines, -10 lines 0 comments Download
M content/shell/browser/shell_devtools_delegate.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/shell/browser/shell_download_manager_delegate.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_login_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_network_delegate.h View 1 chunk +16 lines, -16 lines 0 comments Download
M content/shell/browser/shell_platform_data_aura.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/shell/browser/shell_plugin_service_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_quota_permission_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_resource_dispatcher_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_speech_recognition_manager_delegate.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_views.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/webkit_test_controller.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/shell/common/shell_content_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/shell/geolocation/shell_access_token_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/gc_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/ipc_echo.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/leak_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/shell_content_renderer_client.h View 1 chunk +13 lines, -13 lines 0 comments Download
M content/shell/renderer/shell_render_process_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/renderer/shell_render_view_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/accessibility_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_color_chooser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_color_chooser.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_media_stream_center.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_midi_accessor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_midi_accessor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_speech_recognizer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_user_media_client.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.h View 1 chunk +13 lines, -13 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h View 1 chunk +17 lines, -17 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/spell_check_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/test_plugin.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/shell/renderer/test_runner/text_input_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/webkit_test_runner.h View 1 chunk +51 lines, -51 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/tools/plugin/Tests/DocumentOpenInDestroyStream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/EvaluateJSAfterRemovingPluginElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/FormValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/tools/plugin/Tests/GetURLWithJavaScriptURL.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M content/shell/tools/plugin/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/LogNPPSetWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/NPDeallocateCalledBeforeNPShutdown.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/tools/plugin/Tests/NPPNewFails.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/NPRuntimeCallsWithNullNPP.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/NPRuntimeRemoveProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/tools/plugin/Tests/PassDifferentNPPStruct.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/PluginScriptableNPObjectInvokeDefault.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Ratn (left samsung)
pfeldman@chromium.org: Please review changes in content/shell module
6 years, 2 months ago (2014-10-06 11:30:28 UTC) #2
pfeldman
rs lgtm
6 years, 2 months ago (2014-10-06 12:24:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629143003/1
6 years, 2 months ago (2014-10-06 12:40:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6817b7ccf36baeaacb9cb988171d3fc00be1c405
6 years, 2 months ago (2014-10-06 13:46:09 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 13:46:50 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/449f39a4f8db61782b697e3bacf541416ed13b1e
Cr-Commit-Position: refs/heads/master@{#298227}

Powered by Google App Engine
This is Rietveld 408576698