Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 628873002: replace OVERRIDE and FINAL with override and final in device/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in device/ BUG=417463 Committed: https://crrev.com/53cd3c4dcc32e26f5bf3fb0a1e9cf27bd47b9d6b Cr-Commit-Position: refs/heads/master@{#298289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -514 lines) Patch
M device/bluetooth/bluetooth_adapter_chromeos.h View 4 chunks +33 lines, -33 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.h View 3 chunks +19 lines, -19 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 2 chunks +25 lines, -25 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 3 chunks +21 lines, -21 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 3 chunks +31 lines, -31 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.h View 2 chunks +29 lines, -29 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 2 chunks +29 lines, -29 lines 0 comments Download
M device/bluetooth/bluetooth_discovery_manager_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_connection_chromeos.h View 1 chunk +5 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_notify_session_chromeos.h View 2 chunks +5 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_l2cap_channel_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.h View 2 chunks +18 lines, -18 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_descriptor_chromeos.h View 1 chunk +8 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 2 chunks +16 lines, -16 lines 0 comments Download
M device/bluetooth/bluetooth_rfcomm_channel_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos.h View 3 chunks +8 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_socket_mac.h View 1 chunk +5 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_socket_net.h View 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_socket_win.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_task_manager_win_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M device/hid/device_monitor_linux.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/hid/hid_connection_linux.h View 1 chunk +6 lines, -6 lines 0 comments Download
M device/hid/hid_connection_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M device/hid/hid_connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_connection_win.h View 1 chunk +4 lines, -4 lines 0 comments Download
M device/hid/hid_connection_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/hid/hid_device_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_report_descriptor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/hid/hid_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service_linux.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/hid/hid_service_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/hid/input_service_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/input_service_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_manager.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M device/nfc/nfc_adapter_chromeos.h View 2 chunks +16 lines, -16 lines 0 comments Download
M device/nfc/nfc_chromeos_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M device/nfc/nfc_peer_chromeos.h View 2 chunks +9 lines, -9 lines 0 comments Download
M device/nfc/nfc_tag_chromeos.h View 1 chunk +11 lines, -11 lines 0 comments Download
M device/nfc/nfc_tag_technology.h View 1 chunk +1 line, -1 line 0 comments Download
M device/nfc/nfc_tag_technology_chromeos.h View 1 chunk +7 lines, -7 lines 0 comments Download
M device/serial/data_receiver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/serial/data_receiver.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M device/serial/data_sender.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/serial/data_sink_receiver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/serial/data_sink_receiver.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M device/serial/data_sink_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/data_source_sender.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/serial/data_source_sender.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M device/serial/data_source_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/serial_connection.h View 1 chunk +5 lines, -5 lines 0 comments Download
M device/serial/serial_connection_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M device/serial/serial_device_enumerator_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_device_enumerator_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_device_enumerator_win.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_io_handler_posix.h View 2 chunks +12 lines, -12 lines 0 comments Download
M device/serial/serial_io_handler_win.h View 2 chunks +11 lines, -11 lines 0 comments Download
M device/serial/serial_service_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/serial/serial_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M device/serial/test_serial_io_handler.h View 1 chunk +10 lines, -10 lines 0 comments Download
M device/test/usb_test_gadget_impl.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M device/usb/usb_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_device_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_device_handle_impl.h View 3 chunks +11 lines, -11 lines 0 comments Download
M device/usb/usb_device_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M device/usb/usb_service_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Mostyn Bramley-Moore
@reillyg: can you give this a thumbs-up? The script I used to make this change ...
6 years, 2 months ago (2014-10-04 07:40:27 UTC) #1
Reilly Grant (use Gerrit)
lgtm
6 years, 2 months ago (2014-10-04 08:03:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628873002/1
6 years, 2 months ago (2014-10-04 08:16:59 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/15481)
6 years, 2 months ago (2014-10-04 08:24:16 UTC) #6
Mostyn Bramley-Moore
@keybuk: can you please look at device/bluetooth/* ?
6 years, 2 months ago (2014-10-04 08:53:09 UTC) #8
keybuk
lgtm
6 years, 2 months ago (2014-10-06 18:27:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628873002/1
6 years, 2 months ago (2014-10-06 18:51:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as f1b1ddc35465dda46df3ed21e12d96e93d4ab030
6 years, 2 months ago (2014-10-06 18:59:26 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 19:38:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53cd3c4dcc32e26f5bf3fb0a1e9cf27bd47b9d6b
Cr-Commit-Position: refs/heads/master@{#298289}

Powered by Google App Engine
This is Rietveld 408576698