SyncFS: Implement Get{Normal/Low}PriorityDirtyTracker in MetadataDatabase

SyncFS: Implement Get{Normal/Low}PriorityDirtyTracker in MetadataDatabase


BUG=240165
TEST=n/a

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235705

[nhiroki, 2013-11-18 06:09:49]

PTAL

[tzik, 2013-11-18 06:12:43]

https://codereview.chromium.org/62883004/diff/30001/chrome/browser/sync_file_...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/62883004/diff/30001/chrome/browser/sync_file_...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:943: bool
MetadataDatabase::GetNormalPriorityDirtyTracker(FileTracker* tracker) {
could you mark this function 'const' while you are here?

https://codereview.chromium.org/62883004/diff/30001/chrome/browser/sync_file_...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:949:
dirty_trackers_.erase(itr);
could you leave the tracker in the set?

https://codereview.chromium.org/62883004/diff/30001/chrome/browser/sync_file_...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:959:
low_priority_dirty_trackers_.erase(itr);
ditto

[nhiroki, 2013-11-18 06:27:48]

Thanks, updated.

https://codereview.chromium.org/62883004/diff/30001/chrome/browser/sync_file_...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/62883004/diff/30001/chrome/browser/sync_file_...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:943: bool
MetadataDatabase::GetNormalPriorityDirtyTracker(FileTracker* tracker) {
On 2013/11/18 06:12:43, tzik wrote:
> could you mark this function 'const' while you are here?

Done.

https://codereview.chromium.org/62883004/diff/30001/chrome/browser/sync_file_...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:949:
dirty_trackers_.erase(itr);
On 2013/11/18 06:12:43, tzik wrote:
> could you leave the tracker in the set?

Done.

https://codereview.chromium.org/62883004/diff/30001/chrome/browser/sync_file_...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:959:
low_priority_dirty_trackers_.erase(itr);
On 2013/11/18 06:12:43, tzik wrote:
> ditto

Done.

[tzik, 2013-11-18 06:31:06]

Thanks!
LGTM!

[commit-bot: I haz the power, 2013-11-18 06:54:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/62883004/90001

[commit-bot: I haz the power, 2013-11-18 11:34:50]

Change committed as 235705