Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3829)

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database.cc

Issue 62883004: SyncFS: Implement Get{Normal/Low}PriorityDirtyTracker in MetadataDatabase (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_backend/metadata_database.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database.cc b/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
index 6401a5578469e6928f7281ca1638fcb7783227b5..9493f65b6ca05fe2a2bb7df037fec3e9cf955d5d 100644
--- a/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database.cc
@@ -940,17 +940,24 @@ void MetadataDatabase::LowerTrackerPriority(int64 tracker_id) {
low_priority_dirty_trackers_.insert(tracker);
}
-bool MetadataDatabase::GetNormalPriorityDirtyTracker(FileTracker* tracker) {
- // TODO(tzik): Split |dirty_trackers| to |normal_priority_dirty_trackers|
- // and |low_priority_dirty_trackers|.
- // Add a function to mark a dirty tracker low priority.
- NOTIMPLEMENTED();
- return false;
+bool MetadataDatabase::GetNormalPriorityDirtyTracker(
+ FileTracker* tracker) const {
+ DCHECK(tracker);
+ DirtyTrackers::const_iterator itr = dirty_trackers_.begin();
+ if (itr == dirty_trackers_.end())
+ return false;
+ *tracker = **itr;
+ return true;
}
-bool MetadataDatabase::GetLowPriorityDirtyTracker(FileTracker* tracker) {
- NOTIMPLEMENTED();
- return false;
+bool MetadataDatabase::GetLowPriorityDirtyTracker(
+ FileTracker* tracker) const {
+ DCHECK(tracker);
+ DirtyTrackers::const_iterator itr = low_priority_dirty_trackers_.begin();
+ if (itr == low_priority_dirty_trackers_.end())
+ return false;
+ *tracker = **itr;
+ return true;
}
MetadataDatabase::MetadataDatabase(base::SequencedTaskRunner* task_runner)
@@ -1543,7 +1550,7 @@ scoped_ptr<base::ListValue> MetadataDatabase::DumpFiles(
details->SetString("file_id", tracker->file_id());
if (tracker->has_synced_details() &&
tracker->synced_details().file_kind() == FILE_KIND_FILE)
- details->SetString("md5",tracker->synced_details().md5());
+ details->SetString("md5", tracker->synced_details().md5());
details->SetString("active", tracker->active() ? "true" : "false");
details->SetString("dirty", tracker->dirty() ? "true" : "false");
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698